-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth): add support for Email MFA #13945
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add EMAIL MFA option in fetchMFAPreference * add EMAIL MFA option in updateMFAPreference * update fetchMFAPreference tests * update updateMFAPreference tests * update bundle size * remove redundant assertions
* Confirm Sign In With Email OTP * Confirm Sign In Tests With Email OTP * Update packages/auth/src/types/models.ts Co-authored-by: israx <70438514+israx@users.noreply.github.com> * Fix Errant Pascal Casing --------- Co-authored-by: israx <70438514+israx@users.noreply.github.com>
… swapping (#13794) * chore: enable mfa integ tests * chore: add mfa-setup test def
jjarvisp
requested review from
haverchuck,
cshfang,
HuiSF and
a team
as code owners
October 22, 2024 00:53
jjarvisp
force-pushed
the
feat/email-mfa
branch
from
October 22, 2024 16:09
c3f4855
to
2fa41ae
Compare
HuiSF
reviewed
Oct 24, 2024
packages/auth/__tests__/providers/cognito/signInErrorCases.test.ts
Outdated
Show resolved
Hide resolved
packages/auth/__tests__/providers/cognito/signInErrorCases.test.ts
Outdated
Show resolved
Hide resolved
jjarvisp
force-pushed
the
feat/email-mfa
branch
from
October 24, 2024 20:53
2975f90
to
3493336
Compare
ashika112
reviewed
Oct 24, 2024
packages/auth/__tests__/providers/cognito/signInErrorCases.test.ts
Outdated
Show resolved
Hide resolved
ashika112
reviewed
Oct 24, 2024
ashika112
previously approved these changes
Oct 24, 2024
ashika112
previously approved these changes
Oct 25, 2024
Tahir500
approved these changes
Oct 28, 2024
HuiSF
previously approved these changes
Oct 29, 2024
cshfang
reviewed
Oct 31, 2024
packages/auth/__tests__/providers/cognito/confirmSignInErrorCases.test.ts
Show resolved
Hide resolved
cshfang
previously approved these changes
Oct 31, 2024
ashika112
previously approved these changes
Oct 31, 2024
ashika112
approved these changes
Oct 31, 2024
cshfang
approved these changes
Oct 31, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The purpose of this pull request is to enable support for multi-factor authentication with email.
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.